breaking: Clean up deprecated functionality for v1 #562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #562 +/- ##
==========================================
+ Coverage 39.28% 40.22% +0.94%
==========================================
Files 37 37
Lines 5448 5439 -9
==========================================
+ Hits 2140 2188 +48
+ Misses 3063 3001 -62
- Partials 245 250 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tstirrat15
force-pushed
the
clean-up-deprecations
branch
from
54f4359 to
f54b029
Compare
miparnisari
reviewed
Oct 14, 2025
| registerConsistencyFlags(checkCmd.Flags()) | ||
|
|
||
| permissionCmd.AddCommand(checkBulkCmd) | ||
| checkBulkCmd.Flags().String("revision", "", "optional revision at which to check") |
There was a problem hiding this comment.
this one wasn't marked as hidden, can we actually remove it?
i also see this
readCmd.Flags().String("revision", "", "optional revision at which to check")
_ = readCmd.Flags().MarkHidden("revision")
|
I wonder if we could take this PR as an opportunity to:
This would be in the name of consistency 😄 |
miparnisari
requested changes
Oct 14, 2025
There was a problem hiding this comment.
I ran mage gen:docForPublish and inspected the docs at https://github.com/authzed/zed/blob/main/docs/zed.md. I saw this, can we update it?
Lines 97 to 101 in 57fdb03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of getting a v1 of Zed out the door. We want to take the opportunity to get rid of some deprecated codepaths, which will keep complexity down in the long term.
Changes
zed preview schema compile- it's now justzed schema compilezed watch- it's now justzed relationship watchrevisionflag - use the other consistency flagszed permission lookup- it'szed permission lookup-resourcesestimated-countflag onbulk-delete- uselimitinsteadTesting
Review. See that tests still pass.